Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45826: Fix a crash in suggestions.c by checking for traceback is None #29590

Merged
merged 5 commits into from
Nov 17, 2021
Merged

bpo-45826: Fix a crash in suggestions.c by checking for traceback is None #29590

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12cdff4
Add failing tests
sweeneyde Nov 17, 2021
430aad7
make the tests pass
sweeneyde Nov 17, 2021
daae381
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 17, 2021
04a4ebb
Check for wrong type, not just for None
sweeneyde Nov 17, 2021
80c8388
Merge branch 'suggest_crash' of https://github.com/sweeneyde/cpython …
sweeneyde Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
📜🤖 Added by blurb_it.
  • Loading branch information
@blurb-it
blurb-it[bot] authored Nov 17, 2021
commit daae381613ee01cffe68765d1aa9d283e61b758c
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2021-11-17-08-05-27.bpo-45826.OERoTm.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a crash when calling ``.with_traceback(None)`` on ``NameError``. This occurs internally in ``unittest.TestCase.assertRaises()``.