Clarify that distutils.(plat)include is for CPython's headers #29578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the docs to note that "include" and "platinclude" are for CPython's headers, and not necessarily for headers of third-party libraries. See discussion in: https://discuss.python.org/t/clarification-on-a-wheels-header-data/9305/19
FFY00
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Ugh, this is not super accurate as these directories might include package headers, but I have no clue on how to fix this otherwise. These directories are indeed intended for the Python C-API, not package headers, so I think this change is correct.
It would not be a bad idea to wait for https://bugs.python.org/issue44445 to be resolved to make this change, but I don't think it's required, it's up to you.
merwok
changed the title
|
If bpo-44445 is resolved, it will need a separate PR with a changelog entry. (I confess that I have no idea how installing C headers for extensions should work – to me this seems rather out of scope for Python's packaging ecosystem. So I can't really contribute to that issue.) |
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
…GH-29578) Change the docs to note that "include" and "platinclude" are for CPython's headers, and not necessarily for headers of third-party libraries. See discussion in: https://discuss.python.org/t/clarification-on-a-wheels-header-data/9305/19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the docs to note that "include" and "platinclude" are for CPython's headers, and not necessarily for headers of third-party libraries.
See discussion in: https://discuss.python.org/t/clarification-on-a-wheels-header-data/9305/19