Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-27313: Fix ttk_guionly tests failing on Framework builds on macOS #29411

Merged
merged 2 commits into from
Nov 5, 2021
Merged

bpo-27313: Fix ttk_guionly tests failing on Framework builds on macOS #29411

merged 2 commits into from
Nov 5, 2021

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Nov 4, 2021 •
edited by bedevere-bot
Loading

With this change

Ran 308 tests in 6.152s

OK (skipped=7)

== Tests result: SUCCESS ==

Without this change

Ran 308 tests in 4.753s

FAILED (failures=5, skipped=7)
test test_ttk_guionly failed
test_ttk_guionly failed (5 failures)

== Tests result: FAILURE ==

https://bugs.python.org/issue27313

@ambv ambv added tests Tests in the Lib/test dir needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 4, 2021
@ambv ambv requested a review from ned-deily November 4, 2021 19:50
@ambv ambv changed the title Fix ttk_guionly tests failing on Framework builds on macOS bpo-27313: Fix ttk_guionly tests failing on Framework builds on macOS Nov 4, 2021
@ambv ambv removed the skip issue label Nov 4, 2021
ned-deily
ned-deily approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ambv ambv merged commit e52f9be into python:main Nov 5, 2021
@miss-islington
Copy link
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@ambv ambv deleted the fix-guionly-ttk-tests-on-macos branch November 5, 2021 08:53
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2021
@ambv @miss-islington
bpo-27313: Fix ttk_guionly tests failing on Framework builds on macOS (…
e769896 
…pythonGH-29411)

(cherry picked from commit e52f9be)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-bot
Copy link

GH-29422 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 5, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2021
@ambv @miss-islington
bpo-27313: Fix ttk_guionly tests failing on Framework builds on macOS (…
faac216 
…pythonGH-29411)

(cherry picked from commit e52f9be)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-bot
Copy link

GH-29423 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 5, 2021
ambv added a commit that referenced this pull request Nov 5, 2021
@miss-islington @ambv
bpo-27313: Fix ttk_guionly tests failing on Framework builds on macOS (…
363ecb3 
…GH-29411) (GH-29422)

(cherry picked from commit e52f9be)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Nov 5, 2021
@miss-islington @ambv
bpo-27313: Fix ttk_guionly tests failing on Framework builds on macOS (…
885e57c 
…GH-29411) (GH-29423)

(cherry picked from commit e52f9be)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ambv @miss-islington @bedevere-bot @ned-deily @the-knights-who-say-ni