Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89855: Improve support of non-ASCII identifiers in IDLE #29381

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

gh-89855: Improve support of non-ASCII identifiers in IDLE #29381

wants to merge 2 commits into from

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 3, 2021 •
edited by terryjreedy
Loading

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 3, 2021
@serhiy-storchaka
Copy link
Member Author

It is a draft. Needed tests.

serhiy-storchaka
serhiy-storchaka commented Nov 3, 2021
View reviewed changes
Lib/idlelib/hyperparser.py
@@ -14,13 +14,6 @@
# all ASCII chars that may be the first char of an identifier
_ASCII_ID_FIRST_CHARS = frozenset(string.ascii_letters + "_")

# lookup table for whether 7-bit ASCII chars are valid in a Python identifier
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_IS_ASCII_ID_CHAR[ord(c)] is slower than c in _ASCII_ID_CHARS.

Lib/idlelib/autoexpand.py
while i > 0 and line[i-1] in self.wordchars:
i = i-1
return line[i:]
m = _LAST_WORD_RE.search(line)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test with long lines.

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 4, 2021
@ambv ambv removed the needs backport to 3.9 only security fixes label May 17, 2022
@ambv
Copy link
Contributor

ambv commented May 17, 2022

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.11 only security fixes label May 20, 2022
@terryjreedy terryjreedy changed the title bpo-45692: Improve support of non-ASCII identifiers in IDLE gh-89855: Improve support of non-ASCII identifiers in IDLE Sep 18, 2022
@terryjreedy terryjreedy mentioned this pull request Oct 1, 2022
Open
@hugovk hugovk removed the needs backport to 3.10 only security fixes label Apr 7, 2023
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.11 only security fixes labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gmacky957 Gmacky957 Gmacky957 approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@serhiy-storchaka @ambv @Gmacky957 @hugovk @the-knights-who-say-ni @ezio-melotti @bedevere-bot @terryjreedy