bpo-45545: chdir __exit__ is not safe #29218
Open
+102
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucodery
force-pushed
the
chdir
branch
2 times, most recently
from
6d5fc98 to
d520427
Compare
FFY00
reviewed
Oct 26, 2021
Lib/test/test_contextlib.py
Outdated
| try: | ||
| os.getcwd() | ||
| except OSError as exc: | ||
| if exc.errno == errno.FILENOTFOUND: |
There was a problem hiding this comment.
FILENOTFOUND does not exist, what is it meant to be? ENOENT?
There was a problem hiding this comment.
Whoops, yes you are right. The joys of fixing CI.
|
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
approved these changes
Apr 19, 2022
|
All commit authors signed the Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with these changes to
__exit__there are still some uses of chdir that are unsafe, and will not return to the old cwd after the with block is exited. But for use-cases where returning the old cwd is more of a nicety and not required for the rest of the program, the new keyword argument will allow execution to always continue.https://bugs.python.org/issue45545