Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45388: Bump MAGIC_NUMBER to reflect change in JUMP_ABSOLUTE semantics. #28829

Merged
merged 1 commit into from
Oct 9, 2021
Merged

bpo-45388: Bump MAGIC_NUMBER to reflect change in JUMP_ABSOLUTE semantics. #28829

merged 1 commit into from
Oct 9, 2021

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Oct 9, 2021 •
edited by bedevere-bot
Loading

Fidget-Spinner
Fidget-Spinner approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For anyone confused (I know I was!): we no longer regenerate the frozen hello test files because the frozen module folks (Eric and Guido) have changed how those are tested.

@markshannon markshannon merged commit 5e173f5 into python:main Oct 9, 2021
@markshannon markshannon deleted the bump-magic branch October 9, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markshannon @Fidget-Spinner @the-knights-who-say-ni @bedevere-bot