Skip to content

bpo-43914: Correctly highlight SyntaxError exceptions for invalid generator expression in function calls #28576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2021
Merged

bpo-43914: Correctly highlight SyntaxError exceptions for invalid generator expression in function calls #28576

merged 1 commit into from
Sep 27, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 27, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal changed the title Correctly highlight SyntaxError exceptions for invalid generator expression in function calls bpo-43914: Correctly highlight SyntaxError exceptions for invalid generator expression in function calls Sep 27, 2021
lysnikolaou
lysnikolaou approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@pablogsal pablogsal merged commit e5f13ce into python:main Sep 27, 2021
@pablogsal pablogsal deleted the fix_ranges branch September 27, 2021 13:37
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-28582 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 27, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2021
@pablogsal @miss-islington
bpo-43914: Correctly highlight SyntaxError exceptions for invalid gen…
909783c 
…erator expression in function calls (pythonGH-28576)

(cherry picked from commit e5f13ce)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Sep 27, 2021
@miss-islington @pablogsal
bpo-43914: Correctly highlight SyntaxError exceptions for invalid gen…
9e209d4 
…erator expression in function calls (GH-28576)

(cherry picked from commit e5f13ce)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Sep 29, 2021
@miss-islington @pablogsal
bpo-43914: Correctly highlight SyntaxError exceptions for invalid gen…
3397e31 
…erator expression in function calls (GH-28576)

(cherry picked from commit e5f13ce)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @miss-islington @bedevere-bot @lysnikolaou @the-knights-who-say-ni