bpo-40116: Add insertion order bit-vector to dict values to allow dicts to share keys more freely. #28520
Conversation
… keys more freely.
markshannon
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 8214006 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
No significant performance change https://gist.github.com/markshannon/814e38650cbe4ba1639e31294d4879e6 |
markshannon
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 51c1ec8 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Despite providing no speedup, I'd like to merge this, as it enables compact objects. |
markshannon
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 2a13a2d 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
The build bot failures are cancellations (presumably timeouts). |
|
I'm merging this now as I have https://github.com/faster-cpython/cpython/tree/inline-attributes-with-opt working and it shows measurable speedups as well as reduced memory consumption. |
| @@ -2534,7 +2549,7 @@ dict_merge(PyObject *a, PyObject *b, int override) | |||
| key = entry->me_key; | |||
| hash = entry->me_hash; | |||
| if (other->ma_values) | |||
| value = other->ma_values[i]; | |||
| value = other->ma_values->values[i]; | |||
There was a problem hiding this comment.
I noticed that this change may break order of merged dict.
See faster-cpython/ideas#30 (comment)
https://bugs.python.org/issue40116