Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30814, bpo-30876: Add new import test files to projects. #2851

Merged
merged 1 commit into from
Jul 27, 2017
Merged

bpo-30814, bpo-30876: Add new import test files to projects. #2851

merged 1 commit into from
Jul 27, 2017

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 24, 2017 •
edited by bedevere-bot
Loading

I forget to include directories with new test files in the list of the library directories. This caused that these test files were not installed.

https://bugs.python.org/issue30814

@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 tests Tests in the Lib/test dir labels Jul 24, 2017
@ned-deily ned-deily requested a review from zooba July 24, 2017 18:30
ned-deily
ned-deily approved these changes Jul 24, 2017
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile changes LGTM, thanks! Note that only bpo-30876 was backported to 3.5, so only part of these changes need to go there and should be cherry-picked for 3.5.4 final.

@vstinner
Copy link
Member

I guess that you tested an installed Python on Linux?

@serhiy-storchaka
Copy link
Member Author

No, I didn't test it.

@serhiy-storchaka
Copy link
Member Author

Tested. Tests are passed.

@serhiy-storchaka serhiy-storchaka merged commit d5ed47d into python:master Jul 27, 2017
@serhiy-storchaka serhiy-storchaka deleted the test-import-files branch July 27, 2017 09:24
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 27, 2017
@serhiy-storchaka
[3.6] bpo-30814, bpo-30876: Add new import test files to projects. (p…
94e3a44 
…ythonGH-2851).

(cherry picked from commit d5ed47d)
@bedevere-bot
Copy link

GH-2912 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link

GH-2913 is a backport of this pull request to the 3.5 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 27, 2017
@serhiy-storchaka
[3.5] bpo-30876: Add new import test files to projects. (pythonGH-2851).
a0f4061 
(cherry picked from commit d5ed47d)
serhiy-storchaka added a commit that referenced this pull request Jul 27, 2017
@serhiy-storchaka
[3.6] bpo-30814, bpo-30876: Add new import test files to projects. (G…
95b16a9 
…H-2851). (#2912)

(cherry picked from commit d5ed47d)
serhiy-storchaka added a commit that referenced this pull request Jul 27, 2017
@serhiy-storchaka
[3.5] bpo-30876: Add new import test files to projects. (GH-2851). (#…
f9fbed1 
…2913)

(cherry picked from commit d5ed47d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@ned-deily ned-deily ned-deily approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @vstinner @bedevere-bot @ned-deily @the-knights-who-say-ni