Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45020: Drop the frozen .h files from the repo. #28392

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Sep 16, 2021

This is essentially an un-revert of gh-28375 (reverted in gh-28380). I reverted it due to a (single) buildbot failure. I've adjusted the code we generate for frozen modules in the makefile, based on a hunch about the make version, to fix it.

(Note that I also remove the frozen __hello__.h file, which I missed in the original PR.)

https://bugs.python.org/issue45020

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit b9d87111a6698b4825e4cf7c4355ee0f45902abf 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 16, 2021
@ericsnowcurrently ericsnowcurrently force-pushed the frozen-modules-drop-h-files-again branch from b9d8711 to e7c9d0d Compare September 16, 2021 18:51
@ericsnowcurrently ericsnowcurrently merged commit fdc6b3d into python:main Sep 16, 2021
@ericsnowcurrently
Copy link
Member Author

I'm going to watch the buildbots and make sure the earlier problem is resolved here.

@ericsnowcurrently ericsnowcurrently deleted the frozen-modules-drop-h-files-again branch September 16, 2021 22:14
@gvanrossum
Copy link
Member

FWIW, I kind of doubt that removing the $(srcdir)/ prefix from the files in FROZEN_FILES would fix that buildbot job, but we'll find out eventually if it matters to anyone. (My hunch is that it was a random failure; there are several other variables defining lists of .h files used as dependencies that also use $(srcdir)/.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants