Skip to content

[3.10] bpo-45156: Fixes inifite loop on unittest.mock.seal() (GH-28300) #28326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2021
Merged

[3.10] bpo-45156: Fixes inifite loop on unittest.mock.seal() (GH-28300) #28326

merged 1 commit into from
Sep 14, 2021

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 14, 2021 •
edited by bedevere-bot
Loading

Fixes infinite loop on unittest.mock.seal() of mocks created by
unittest.create_autospec().

Co-authored-by: Dong-hee Na donghee.na92@gmail.com
(cherry picked from commit 7f60c9e)

Co-authored-by: Nikita Sobolev mail@sobolevn.me

https://bugs.python.org/issue45156

@sobolevn @miss-islington
bpo-45156: Fixes inifite loop on unittest.mock.seal() (pythonGH-28300)
50abca7 
Fixes infinite loop on unittest.mock.seal() of mocks created by
unittest.create_autospec().

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit 7f60c9e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@miss-islington
Copy link
Contributor Author

miss-islington commented Sep 14, 2021

@sobolevn and @vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request Sep 14, 2021
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Sep 14, 2021

@sobolevn and @vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

miss-islington commented Sep 14, 2021

@sobolevn and @vstinner: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner vstinner merged commit fd74d26 into python:3.10 Sep 14, 2021
@miss-islington miss-islington deleted the backport-7f60c9e-3.10 branch September 14, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@cjw296 cjw296 Awaiting requested review from cjw296 cjw296 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @sobolevn