Skip to content

[3.9] bpo-42560: rewrite of Tkinter docs "life preserver" (GH-27842) #27911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 23, 2021

Co-authored-by: Łukasz Langa lukasz@langa.pl
(cherry picked from commit 08830a4)

Co-authored-by: Mark Roseman mark@markroseman.com

https://bugs.python.org/issue42560

@miss-islington
Copy link
Contributor Author

@roseman and @ambv: Status check is done, and it's a success ✅ .

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 08830a4)

Co-authored-by: Mark Roseman <mark@markroseman.com>
@miss-islington
Copy link
Contributor Author

@roseman and @ambv: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@roseman and @ambv: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@roseman and @ambv: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@roseman and @ambv: Status check is done, and it's a failure ❌ .

@ambv ambv closed this Aug 23, 2021
@miss-islington miss-islington deleted the backport-08830a4-3.9 branch August 23, 2021 19:05
@terryjreedy
Copy link
Member

terryjreedy commented Aug 28, 2021

Given that there was no merge conflict, why was this closed? If it it not going to be merged, the label on #27842 should be removed. I am asking in particular because bpo-45029 is about the old example, run in 3.9, that this replaces. So backporting the replacement seems like a good idea.

@E-Paine
Copy link
Contributor

E-Paine commented Sep 17, 2021

@ambv Can we reopen this for merge? As Terry said, bpo-45029 is related to this, so IMO it would be nice to get this in the 3.9 docs.

@hpmason hpmason mannequin mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants