Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44984: Rewrite test_null_strings in _testcapi #27904

Merged
merged 1 commit into from
Aug 23, 2021
Merged

bpo-44984: Rewrite test_null_strings in _testcapi #27904

merged 1 commit into from
Aug 23, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 23, 2021 •
edited by bedevere-bot
Loading

Test also PyObject_Repr(NULL) and PyObject_Bytes(NULL).

https://bugs.python.org/issue44984

@serhiy-storchaka
bpo-44984: Rewrite test_null_strings in _testcapi
84524e6 
Test also PyObject_Repr(NULL) and PyObject_Bytes(NULL).
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Aug 23, 2021
@ambv ambv merged commit 4d68917 into python:main Aug 23, 2021
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4d689173861257c69adc6dc1dca4171946ddb57f 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 23, 2021
@bedevere-bot
Copy link

GH-27908 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2021
@serhiy-storchaka @miss-islington
bpo-44984: Rewrite test_null_strings in _testcapi (pythonGH-27904)
a43dbf8 
Test also PyObject_Repr(NULL) and PyObject_Bytes(NULL).
(cherry picked from commit 4d68917)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ambv pushed a commit to ambv/cpython that referenced this pull request Aug 23, 2021
@serhiy-storchaka @ambv
[3.9] bpo-44984: Rewrite test_null_strings in _testcapi (pythonGH-27904)
6a1ba64 
Test also PyObject_Repr(NULL) and PyObject_Bytes(NULL)..
(cherry picked from commit 4d68917)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 23, 2021
@bedevere-bot
Copy link

GH-27910 is a backport of this pull request to the 3.9 branch.

ambv added a commit that referenced this pull request Aug 23, 2021
@ambv @serhiy-storchaka
[3.9] bpo-44984: Rewrite test_null_strings in _testcapi (GH-27904) (G…
b0df288 
…H-27910)

Test also PyObject_Repr(NULL) and PyObject_Bytes(NULL)..
(cherry picked from commit 4d68917)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Aug 23, 2021
@miss-islington @serhiy-storchaka
bpo-44984: Rewrite test_null_strings in _testcapi (GH-27904)
6ff7fef 
Test also PyObject_Repr(NULL) and PyObject_Bytes(NULL).
(cherry picked from commit 4d68917)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni