bpo-30978: str.format_map() now passes key lookup exceptions through. #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
needs backport to 2.7
type-bug
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericvsmith, @pitrou and @doerwalter to be potential reviewers. |
A test fails:ERROR: test_match_getitem (test.test_re.ReTests) Traceback (most recent call last): File "/home/travis/build/python/cpython/Lib/test/test_re.py", line 472, in test_match_getitem IndexError: no such group You should document this behaviour change in the NEWS entry (and fix the test). |
|
Other than the failing test in test_re, this looks good to me. |
vstinner
approved these changes
Jul 21, 2017
ericvsmith
reviewed
Jul 21, 2017
| @@ -1 +1,2 @@ | |||
| str.format_map() now passes key lookup exceptions through. | |||
| Previousle any exception was replaced with a KeyError exception. | |||
There was a problem hiding this comment.
Typo: Previousle -> Previously
rhettinger
approved these changes
Jul 21, 2017
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Aug 3, 2017
…rough. (pythonGH-2790) Previously any exception was replaced with a KeyError exception. (cherry picked from commit 5075416)
|
GH-2992 is a backport of this pull request to the 3.6 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.