Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-4442: Document use of __new__ for subclasses of immutable types #27866

Merged
merged 4 commits into from
Aug 22, 2021
Merged

bpo-4442: Document use of __new__ for subclasses of immutable types #27866

merged 4 commits into from
Aug 22, 2021

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Aug 21, 2021 •
edited by bedevere-bot
Loading

@rhettinger rhettinger added docs Documentation in the Doc dir skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Aug 21, 2021
ambv
ambv approved these changes Aug 22, 2021
View reviewed changes
Copy link
Contributor

@ambv ambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

@ambv ambv merged commit eec340e into python:main Aug 22, 2021
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @rhettinger and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eec340ea3af27887fcaac4029ebdee99f3713bff 3.9

@bedevere-bot
Copy link

GH-27899 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 22, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2021
@rhettinger @miss-islington
bpo-4442: Document use of __new__ for subclasses of immutable types (p…
8d1140c 
…ythonGH-27866)

(cherry picked from commit eec340e)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@ambv
Copy link
Contributor

ambv commented Aug 22, 2021

I'll deal with the 3.9 conflict.

ambv pushed a commit to ambv/cpython that referenced this pull request Aug 22, 2021
@rhettinger @ambv
[3.9] bpo-4442: Document use of __new__ for subclasses of immutable t…
a1fc2b1 
…ypes (pythonGH-27866).

(cherry picked from commit eec340e)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-bot
Copy link

GH-27900 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 22, 2021
miss-islington added a commit that referenced this pull request Aug 22, 2021
@miss-islington @rhettinger
bpo-4442: Document use of __new__ for subclasses of immutable types (G…
0627918 
…H-27866)

(cherry picked from commit eec340e)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
ambv added a commit that referenced this pull request Aug 22, 2021
@ambv @rhettinger
[3.9] bpo-4442: Document use of __new__ for subclasses of immutable t…
ac87b07 
…ypes (GH-27866) (GH-27900)

(cherry picked from commit eec340e)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv ambv approved these changes

Assignees

@ambv ambv

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhettinger @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni