Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44698: Restore complex pow behaviour for small integral exponents #27772

Merged
merged 8 commits into from
Aug 17, 2021
Merged

bpo-44698: Restore complex pow behaviour for small integral exponents #27772

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4b0564b
Restore the old check for integer exponent
mdickinson Aug 15, 2021
8895a6a
Add regression test
mdickinson Aug 15, 2021
8f557fa
News entry
mdickinson Aug 15, 2021
a925b1c
Remove unused variable
mdickinson Aug 15, 2021
c03c9a5
Use 'floor' rather than 'rint', just in case there are platforms that…
mdickinson Aug 15, 2021
6ac2785
More comprehensive tests
mdickinson Aug 15, 2021
b0babe9
Put new tests into their own method
mdickinson Aug 16, 2021
a74c34e
Remove unnecessary local variable; restore comment
mdickinson Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add regression test
  • Loading branch information
@mdickinson
mdickinson committed Aug 15, 2021
commit 8895a6a357a987876daa19932b04c4076b7230b3
16 changes: 16 additions & 0 deletions Lib/test/test_complex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,22 @@ def test_pow(self):
except OverflowError:
pass

# Check that z**2.0 is handled identically to z**2.
values = [
complex(5.0, 12.0),
complex(5.0e100, 12.0e100),
complex(-4.0, INF),
complex(INF, 0.0),
]
for value in values:
with self.subTest(value=value):
int_square = value**2
float_square = value**2.0
self.assertFloatsAreIdentical(
int_square.real, float_square.real)
self.assertFloatsAreIdentical(
int_square.imag, float_square.imag)

def test_boolcontext(self):
for i in range(100):
self.assertTrue(complex(random() + 1e-6, random() + 1e-6))
Expand Down