Skip to content

[3.10] bpo-44524: Fix an issue wherein _GenericAlias._name was not properly set for specialforms (GH-27614) #27632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2021
Merged

[3.10] bpo-44524: Fix an issue wherein _GenericAlias._name was not properly set for specialforms (GH-27614) #27632

merged 1 commit into from
Aug 6, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2021 •
edited by bedevere-bot
Loading

Co-authored-by: Ken Jin 28750310+Fidget-Spinner@users.noreply.github.com
Co-authored-by: Łukasz Langa lukasz@langa.pl
(cherry picked from commit 8bdf12e)

Co-authored-by: Bas van Beek 43369155+BvB93@users.noreply.github.com

https://bugs.python.org/issue44524

@BvB93 @miss-islington
bpo-44524: Fix an issue wherein _GenericAlias._name was not properl…
7311293 
…y set for specialforms (pythonGH-27614)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 8bdf12e)

Co-authored-by: Bas van Beek <43369155+BvB93@users.noreply.github.com>
@miss-islington
Copy link
Contributor Author

@BvB93 and @ambv: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request Aug 6, 2021
Merged
@miss-islington
Copy link
Contributor Author

@BvB93 and @ambv: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Aug 6, 2021
@miss-islington
Copy link
Contributor Author

@BvB93 and @ambv: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@BvB93 and @ambv: Status check is done, and it's a success ✅ .

@ambv ambv requested a review from pablogsal August 6, 2021 15:05
@ambv
Copy link
Contributor

ambv commented Aug 6, 2021

@pablogsal, this fixes an issue where some special forms in typing could have __name__ set to None.

@miss-islington miss-islington merged commit 36a2497 into python:3.10 Aug 6, 2021
@miss-islington miss-islington deleted the backport-8bdf12e-3.10 branch August 6, 2021 17:08
@farcat farcat mannequin mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @ambv @pablogsal @the-knights-who-say-ni @bedevere-bot @BvB93