Improve doc of IncrementalEncoder #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getstate and setstate are instance methods just like encode and reset.
|
@zmwangx, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @ncoghlan and @benjaminp to be potential reviewers. |
|
IMO this is trivial enough that no bpo issue is needed. |
Mariatta
approved these changes
Sep 10, 2017
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 10, 2017
getstate and setstate are instance methods, same as encode and reset. (cherry picked from commit 30644de)
|
GH-3475 is a backport of this pull request to the 3.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getstateandsetstateare instance methods just likeencodeandreset, but currently they look like static/class methods in the docs, which is slightly confusing: