Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30946: Remove obsolete fallback code in readline module #2738

Merged
merged 4 commits into from
Jul 18, 2017
Merged

bpo-30946: Remove obsolete fallback code in readline module #2738

merged 4 commits into from
Jul 18, 2017

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jul 17, 2017

No description provided.

@pitrou pitrou changed the title Remove obsolete fallback code in readline module bpo-30946: Remove obsolete fallback code in readline module Jul 17, 2017
@pitrou
Copy link
Member Author

pitrou commented Jul 18, 2017

@vadmium, @serhiy-storchaka, any objection to this?

serhiy-storchaka
serhiy-storchaka approved these changes Jul 18, 2017
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If some problems will occurred with libedit we can special case this.

@pitrou
Copy link
Member Author

pitrou commented Jul 18, 2017

Thank you Serhiy!

@pitrou pitrou merged commit f474c5a into python:master Jul 18, 2017
@pitrou pitrou deleted the readline_obsolete_code branch July 18, 2017 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pitrou @serhiy-storchaka @the-knights-who-say-ni