Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in dataclasses documentation #27360

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Fix typo in dataclasses documentation #27360

merged 1 commit into from
Jul 26, 2021

Conversation

tmke8
Copy link
Contributor

@tmke8 tmke8 commented Jul 26, 2021

"affect" -> "effect"

As this is just fixing a typo, I believe it does not need an issue number.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@thomkeh

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@tmke8
Copy link
Contributor Author

tmke8 commented Jul 26, 2021

I signed the contributor agreement, and am now waiting for it to be processed. Though I'm also completely fine with someone else opening a PR with the same change. I don't really think this contribution passes the threshold of originality to be copyrightable anyway 😄

@ericvsmith ericvsmith merged commit aa0e4a6 into python:main Jul 26, 2021
@bedevere-bot
Copy link

@ericvsmith: Please replace # with GH- in the commit message next time. Thanks!

@ericvsmith
Copy link
Member

Thanks for the fix. I agree we can skip the CLA for this.

@arhadthedev arhadthedev mentioned this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants