Skip to content

bpo-43219: handle Solaris as well #27257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2021
Merged

bpo-43219: handle Solaris as well #27257

merged 1 commit into from
Jul 20, 2021

Conversation

@kulikjak
Copy link
Contributor

@kulikjak kulikjak commented Jul 20, 2021 •
edited by bedevere-bot
Loading

On Solaris (I checked this on Oracle and SmartOS), the error is:

NotADirectoryError: [Errno 20] Not a directory: 'not_a_dir/'

which I think belongs to the 'errors are not confusing' category with Windows and macOS.

https://bugs.python.org/issue43219

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jul 20, 2021
@gpshead gpshead merged commit 6564656 into python:main Jul 20, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jul 20, 2021

Thanks @kulikjak for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 20, 2021

Sorry @kulikjak and @gpshead, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6564656495d456a1bcc1aaa06abfc696209f37b2 3.10

@bedevere-bot
Copy link

bedevere-bot commented Jul 20, 2021

GH-27267 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2021
@kulikjak @miss-islington
bpo-43219: skip Solaris in the test as well (pythonGH-27257)
d9acfeb 
(cherry picked from commit 6564656)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
@gpshead gpshead added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Jul 20, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jul 20, 2021

Thanks @kulikjak for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 20, 2021
@bedevere-bot
Copy link

bedevere-bot commented Jul 20, 2021

GH-27268 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2021
@kulikjak @miss-islington
bpo-43219: skip Solaris in the test as well (pythonGH-27257)
9fe020a 
(cherry picked from commit 6564656)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
miss-islington added a commit that referenced this pull request Jul 20, 2021
@miss-islington
[3.9] bpo-43219: skip Solaris in the test as well (GH-27257) (GH-27267)
dae4928 
(cherry picked from commit 6564656)


Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>

Automerge-Triggered-By: GH:gpshead
miss-islington added a commit that referenced this pull request Jul 20, 2021
@miss-islington
[3.10] bpo-43219: skip Solaris in the test as well (GH-27257) (GH-27268)
574da46 
(cherry picked from commit 6564656)


Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>

Automerge-Triggered-By: GH:gpshead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kulikjak @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni