Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44631: Make the repr() of the _Environ class more readable. #27128

Merged
merged 5 commits into from
Jul 20, 2021
Merged

bpo-44631: Make the repr() of the _Environ class more readable. #27128

merged 5 commits into from
Jul 20, 2021

Conversation

Leonardofreua
Copy link
Contributor

@Leonardofreua Leonardofreua commented Jul 13, 2021 •
edited by bedevere-bot
Loading

  • Refactored the repr() of the _Environ class

  • Update os.py (_Environ)

  • Update test_os.py (EnvironTests)

https://bugs.python.org/issue44631

@Leonardofreua
bpo-44631: Make the repr() of the _Environ class more readable.
9252dce 
* Refactored the repr() of the _Environ class

* Update os.py (_Environ)

* Update test_os.py (EnvironTests)
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Leonardofreua

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

vedgar
vedgar suggested changes Jul 14, 2021
View reviewed changes
ambv
ambv requested changes Jul 15, 2021
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Leonardofreua and others added 3 commits July 15, 2021 10:55
@Leonardofreua @ambv
Update Lib/os.py
a60b0bb 
Unified item formatting in the formatted_items variable

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@Leonardofreua
bpo-44631: Remove the _mock_os_environ_repr method
83501c4 
* Update test_os.py
@Leonardofreua
bpo-44631: Update 2021-07-13-22-25-13.bpo-44631.qkGwe4.rst
22a0bbc 
* Removed mention of test test___repr__
@ambv
Copy link
Contributor

ambv commented Jul 15, 2021

Please sign the CLA, @Leonardofreua, and we're good to go.

@Leonardofreua
Copy link
Contributor Author

@ambv I've already signed up. I'm waiting one business day for the subscription to work.

@ambv ambv merged commit 85fa3b6 into python:main Jul 20, 2021
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@Leonardofreua Leonardofreua deleted the bpo-44631 branch July 20, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedgar vedgar vedgar requested changes

@ambv ambv ambv requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Leonardofreua @the-knights-who-say-ni @bedevere-bot @ambv @vedgar