Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40939: Remove documentation for PyParser_* & add porting notes #26855

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

encukou
Copy link
Member

@encukou encukou commented Jun 22, 2021

I tried to be relatively thorough and give lots of links.
One reason is that this wasn't deprecated very long; also it seems people running into this tend to not be familiar with similar APIs.

https://bugs.python.org/issue40939

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks for doing this. I like how the porting guide covers the 3 main input types for AST construction in the old API.

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@encukou encukou merged commit 29987f7 into python:main Jun 24, 2021
@miss-islington
Copy link
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@encukou encukou deleted the pyparser-docs-removal branch June 24, 2021 12:57
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2021
…ythonGH-26855)

I tried to be relatively thorough and give lots of links.
One reason is that this wasn't deprecated very long; also it seems people running into this tend to not be familiar with similar APIs.

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
(cherry picked from commit 29987f7)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 24, 2021
@bedevere-bot
Copy link

GH-26898 is a backport of this pull request to the 3.10 branch.

encukou added a commit that referenced this pull request Jun 28, 2021
…H-26855) (GH-26898)

I tried to be relatively thorough and give lots of links.
One reason is that this wasn't deprecated very long; also it seems people running into this tend to not be familiar with similar APIs.

(cherry picked from commit 29987f7)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants