Skip to content

bpo-13814: Explain why generators are not context managers #26835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2021
Merged

bpo-13814: Explain why generators are not context managers #26835

merged 3 commits into from
Jun 21, 2021

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 21, 2021 •
edited by bedevere-bot
Loading

Original patch by Aidan Lowe.

https://bugs.python.org/issue13814

@terryjreedy terryjreedy added docs Documentation in the Doc dir needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jun 21, 2021
@terryjreedy terryjreedy self-assigned this Jun 21, 2021
iritkatriel
iritkatriel reviewed Jun 21, 2021
View reviewed changes
terryjreedy and others added 2 commits June 21, 2021 16:25
@terryjreedy @iritkatriel
Update Doc/faq/design.rst
a88be2d 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@terryjreedy @iritkatriel
Update Doc/faq/design.rst
8b745bc 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@terryjreedy terryjreedy merged commit 51f45d0 into python:main Jun 21, 2021
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2021
@terryjreedy @miss-islington
bpo-13814: Explain why generators are not context managers (pythonGH-…
142e7ec 
…26835)

Put entry in Design FAQ after a question about a context manager for assignment.
Original patch by Aidan Lowe.
(cherry picked from commit 51f45d0)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

GH-26836 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 21, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2021
@terryjreedy @miss-islington
bpo-13814: Explain why generators are not context managers (pythonGH-…
b6ce9b8 
…26835)

Put entry in Design FAQ after a question about a context manager for assignment.
Original patch by Aidan Lowe.
(cherry picked from commit 51f45d0)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

GH-26837 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 21, 2021
@terryjreedy terryjreedy deleted the withgen branch June 21, 2021 22:01
terryjreedy added a commit that referenced this pull request Jun 21, 2021
@miss-islington @terryjreedy
bpo-13814: Explain why generators are not context managers (GH-26835)
1e16217 
Put entry in Design FAQ after a question about a context manager for assignment.
Original patch by Aidan Lowe.
(cherry picked from commit 51f45d0)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this pull request Jun 21, 2021
@miss-islington @terryjreedy
bpo-13814: Explain why generators are not context managers (GH-26835)
d881002 
Put entry in Design FAQ after a question about a context manager for assignment.
Original patch by Aidan Lowe.
(cherry picked from commit 51f45d0)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

@terryjreedy terryjreedy

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@terryjreedy @miss-islington @bedevere-bot @iritkatriel @the-knights-who-say-ni