bpo-27827: pathlib: identify a greater range of reserved filename on Windows. #26698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pathlib.PureWindowsPath.is_reserved()` now identifies as reserved filenames with trailing spaces or colons. Co-Authored-By: Eryk Sun <eryksun@gmail.com>
jaykrell
reviewed
Jul 8, 2021
| # path processing. Thus relative paths are not resolved and slash is not | ||
| # translated to backslash. It has the native NT path limit of 32767 | ||
| # characters, but a bit less after resolving device symbolic links, | ||
| # such as '\??\C:' => '\Device\HarddiskVolume2'. |
There was a problem hiding this comment.
Do those in-memory symlinks really detract from the limit?
I.e. is a new full path really formed,
or just the remaining part is passed to the FS driver?
ambv
added
needs backport to 3.9
|
Thanks @barneygale for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 28, 2021
…ythonGH-26698) `pathlib.PureWindowsPath.is_reserved()` now identifies as reserved filenames with trailing spaces or colons. Co-authored-by: Barney Gale <barney.gale@foundry.com> Co-authored-by: Eryk Sun <eryksun@gmail.com> (cherry picked from commit 56c1f6d) Co-authored-by: Barney Gale <barney.gale@gmail.com>
|
GH-27421 is a backport of this pull request to the 3.10 branch. |
|
GH-27422 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 28, 2021
…ythonGH-26698) `pathlib.PureWindowsPath.is_reserved()` now identifies as reserved filenames with trailing spaces or colons. Co-authored-by: Barney Gale <barney.gale@foundry.com> Co-authored-by: Eryk Sun <eryksun@gmail.com> (cherry picked from commit 56c1f6d) Co-authored-by: Barney Gale <barney.gale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathlib.PureWindowsPath.is_reserved()now identifies as reserved filenames with trailing spaces or colons.All credit to Eryk Sun for this patch.
https://bugs.python.org/issue27827