Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44345: Fix comment in parser.c #26615

Merged
merged 5 commits into from
Jun 9, 2021

Conversation

anonaka
Copy link
Contributor

@anonaka anonaka commented Jun 8, 2021

Fix the first line comment in parser.c

https://bugs.python.org/issue44345

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@anonaka

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@anonaka
Copy link
Contributor Author

anonaka commented Jun 8, 2021

I have just signed the CLA.

Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not showing yet that you signed CLA but I think it will with time.

Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will let @lysnikolaou merge this one.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Congrats @anonaka on your first contribution!

@lysnikolaou
Copy link
Member

I'm gonna go ahead and merge this without the CLA label change, since it's a small change.

@lysnikolaou lysnikolaou merged commit aef1b58 into python:main Jun 9, 2021
@anonaka anonaka deleted the fix-comment-in-parser-dot-c-2 branch June 9, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants