-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40468: Move help extension settings to extensions page of dialog. #26593
Conversation
I manually tested that I can edit, delete, add, and save entries and see changes in another IDLE. The extension stuff needs to be factored out into a separate class, like the other pages, but it works as is. Am planning to merge after sleep and re-review and possible tweaks. See comment on issue also. |
Because there is no class ExtPage (yet) and because the dialog has gridded widgets, an error message said the label frames had to be gridded rather than packed. I don't know why the same is not true within the frame classes. Anyway, I just guessed at what the arguments should be after the change to grid. I stuck a blank label between the two label frames so they were not jammed together. There is probably a better way. This page definitely needs a followup, tested on all 3 OSes (see below). Maybe all the pages would be better gridded, but by someone who understands the arguments. Maybe we should look at the various themes available on each OS. Or create our own. And definitely reconsider the look and feel. As far as I know, the reliefs are as they were 20 years ago. I'd like to try giving the labelled frame a different background from the page frames. But this is a different discussion, to be done after we have the right widgets present. The only paned window I am familiar with is turtledemo. At least on Windows, the divider is quite different from anything on this dialog. (Edited from here.) The checkboxes are buggy. Selecting them displays a dotted rectangle to the right, which can be clicked on to uncheck and check the boxes. I see blank space below the helplist box, indicating that this page is not forcing the dialog height. |
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
…ythonGH-26593) These are the settings that extend the help menu. Moving them shortens the dialog and will help with it being too tall for small screens. (cherry picked from commit ab36b9f) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
GH-26612 is a backport of this pull request to the 3.10 branch. |
GH-26613 is a backport of this pull request to the 3.9 branch. |
…ythonGH-26593) These are the settings that extend the help menu. Moving them shortens the dialog and will help with it being too tall for small screens. (cherry picked from commit ab36b9f) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This shortens the dialog and will help issues with it being too tall for small screens.
https://bugs.python.org/issue40468