Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40468: Move help extension settings to extensions page of dialog. #26593

Merged
merged 7 commits into from
Jun 8, 2021

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 8, 2021

This shortens the dialog and will help issues with it being too tall for small screens.

https://bugs.python.org/issue40468

@terryjreedy terryjreedy added type-bug An unexpected behavior, bug, or error needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jun 8, 2021
@terryjreedy terryjreedy self-assigned this Jun 8, 2021
@terryjreedy
Copy link
Member Author

terryjreedy commented Jun 8, 2021

I manually tested that I can edit, delete, add, and save entries and see changes in another IDLE. The extension stuff needs to be factored out into a separate class, like the other pages, but it works as is. Am planning to merge after sleep and re-review and possible tweaks. See comment on issue also.

@terryjreedy terryjreedy requested a review from taleinat June 8, 2021 07:24
@E-Paine
Copy link
Contributor

E-Paine commented Jun 8, 2021

I like this and it does indeed reduce window height. However, the current usage of reliefs suggest (IMO) it is a paned window (which is not the case). I think this is because we can scroll the content in both the top and bottom frames (which is not the case elsewhere). This is not a major issue, but maybe something worth considering.

The other thing I have encountered is that the window is different heights when an extension is or is not selected:
idle options height

@terryjreedy
Copy link
Member Author

terryjreedy commented Jun 8, 2021

Because there is no class ExtPage (yet) and because the dialog has gridded widgets, an error message said the label frames had to be gridded rather than packed. I don't know why the same is not true within the frame classes. Anyway, I just guessed at what the arguments should be after the change to grid. I stuck a blank label between the two label frames so they were not jammed together. There is probably a better way. This page definitely needs a followup, tested on all 3 OSes (see below).

Maybe all the pages would be better gridded, but by someone who understands the arguments. Maybe we should look at the various themes available on each OS. Or create our own. And definitely reconsider the look and feel. As far as I know, the reliefs are as they were 20 years ago. I'd like to try giving the labelled frame a different background from the page frames. But this is a different discussion, to be done after we have the right widgets present.

The only paned window I am familiar with is turtledemo. At least on Windows, the divider is quite different from anything on this dialog.

(Edited from here.)
You must be on Linux. When I select the Extensions tab, zzdummy is selected and its detail present. (Even though current extension is set to None.) I cannot unselect it. So I see no height change. On the other hand, I see space under the helplist box.

The checkboxes are buggy. Selecting them displays a dotted rectangle to the right, which can be clicked on to uncheck and check the boxes. I see blank space below the helplist box, indicating that this page is not forcing the dialog height.

@terryjreedy terryjreedy merged commit ab36b9f into python:main Jun 8, 2021
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2021
…ythonGH-26593)

These are the settings that extend the help menu.  Moving them shortens the dialog and will help with it being too tall for small screens.
(cherry picked from commit ab36b9f)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 8, 2021
@bedevere-bot
Copy link

GH-26612 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

GH-26613 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 8, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2021
…ythonGH-26593)

These are the settings that extend the help menu.  Moving them shortens the dialog and will help with it being too tall for small screens.
(cherry picked from commit ab36b9f)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy terryjreedy deleted the helpsrc branch June 8, 2021 19:35
miss-islington added a commit that referenced this pull request Jun 8, 2021
…H-26593)

These are the settings that extend the help menu.  Moving them shortens the dialog and will help with it being too tall for small screens.
(cherry picked from commit ab36b9f)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy pushed a commit that referenced this pull request Jun 8, 2021
…H-26593)

These are the settings that extend the help menu.  Moving them shortens the dialog and will help with it being too tall for small screens.
(cherry picked from commit ab36b9f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants