bpo-44254: On Mac, remove disfunctional colors from turtledemo buttons #26448
Conversation
On macOS, tk sometimes defers to system settings. Customized white on system white meant unreadable text.
terryjreedy
added
type-bug
| self.clear_btn = Button(root, text=" CLEAR ", font=btnfont, | ||
| fg="white", disabledforeground="#fed", | ||
| command = self.clearCanvas) | ||
| if darwin: # Leave Mac button colors alone - #44254. |
There was a problem hiding this comment.
It duplicates a lot of code which is the same on all platforms. Would not be better to factor out variable parts?
if darwin:
foreground = ...
disabledforeground = ...
else:
foreground = ...
disabledforeground = ...
There was a problem hiding this comment.
This is an interim patch changing Mac only that I hope gets into .0b2 to workaround the tk bug on Mac (see issue). I initially removed both colors for Mac, but the default buttons are buggy depending on the users choice of theme. The default disabled foreground on Mac is fine as far as I know, and I don't especially care as being readable then does not matter. After I decide what to do with non-Mac, I will consider whether to even set disabledforeground on non-Mac. I want to try multiple colors on non-Mac, and if so, the code will not be exactly parallel. And maybe use ttk widgets.
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
|
GH-26449 is a backport of this pull request to the 3.10 branch. |
bedevere-bot
removed
needs backport to 3.10
|
GH-26450 is a backport of this pull request to the 3.9 branch. |
pythonGH-26448) On macOS, tk defers to system setting for button background when in normal state. Give turtledemo button text a color that works on either light or dark background. (cherry picked from commit af5a324) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
pythonGH-26448) On macOS, tk defers to system setting for button background when in normal state. Give turtledemo button text a color that works on either light or dark background. (cherry picked from commit af5a324) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
On macOS, tk partly defers to system settings. Custom white
on system white meant unreadable text.
https://bugs.python.org/issue44254