bpo-44222: Improve _removeHandlerRef() for a very long _handlerList#26325
bpo-44222: Improve _removeHandlerRef() for a very long _handlerList#26325miss-islington merged 3 commits intopython:mainfrom
Conversation
The list lookups become a big burden for very long lists. This patch changes the "happy flow" path of 2 lookups into 1 lookup.
Jongy
force-pushed
the
improve-removehandlerprefix
branch
from
da586c8 to
7453857
Compare
vsajip
left a comment
vsajip
left a comment
There was a problem hiding this comment.
Please remove the NEWS entry, as per the comment on it.
| @@ -0,0 +1,2 @@ | |||
| Improve the performance of _removeHandlerRef() for very long _handlerLists. | |||
There was a problem hiding this comment.
I've added the skip-news label, so this file shouldn't be necessary (it's too low-level a detail for the NEWS file). You can remove this, your name should appear as author in the commit message.
There was a problem hiding this comment.
Still haven't got the hang of when we add NEWS entry and when we don't 😞 (in previous PRs I've added NEWS files for even lower-level changes, such as 3505261. Perhaps because they were bugfixes and not just improvements?)
Anyway - sure, removing it
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This reverts commit 43782f8.
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vsajip: please review the changes made to this pull request. |
|
Thanks for reviewing @vsajip :) |
5 participants
The list lookups become a big burden for very long lists.
This patch changes the "happy flow" path of 2 lookups into 1 lookup.
https://bugs.python.org/issue44222
Automerge-Triggered-By: GH:vsajip