bpo-30870: IDLE: Change sample font when select by key-up/down #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryjreedy
requested changes
Jul 8, 2017
There was a problem hiding this comment.
I am about to submit a revision with the changes indicated, plus replacing list_fonts, a verb, with fontlist, a noun, plus a line to activate the current font, and a change to focus specifically on fontlist. Otherwise, keys do not work on windows until a font is clicked to focus and activate. Also will add NEWS file.
I plan to then work on tests. But not tonight. I hope to merge this tomorrow.
Lib/idlelib/configdialog.py
Outdated
| '<ButtonRelease-1>', self.on_list_fonts_button_release) | ||
| self.list_fonts.bind('<ButtonRelease-1>', self.on_list_fonts_button_release) | ||
| self.list_fonts.bind('<KeyRelease-Up>', self.on_list_fonts_key_release) | ||
| self.list_fonts.bind('<KeyRelease-Down>', self.on_list_fonts_key_release) |
There was a problem hiding this comment.
I replaced these with one binding to <>
Lib/idlelib/configdialog.py
Outdated
| font = self.list_fonts.get(ACTIVE) | ||
| self.font_name.set(font.lower()) | ||
| self.set_font_sample() | ||
|
|
There was a problem hiding this comment.
I replaced both functions with one that used event.type to select the index.
terryjreedy
approved these changes
Jul 9, 2017
|
Manual test passed. Effort to write unittest failed. Will add post to issue. |
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jul 9, 2017
…ythonGH-2617) Patch by Louie Lu. (cherry picked from commit bb2bae8)
terryjreedy
added a commit
that referenced
this pull request
Jul 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.