Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve speed and accuracy for correlation() #26135

Merged
merged 16 commits into from
May 15, 2021
Merged

Improve speed and accuracy for correlation() #26135

merged 16 commits into from
May 15, 2021

Conversation

rhettinger
Copy link
Contributor

This is the same as the previous improvement to linear_regression().

  • Repeated computation of xbar and ybar factored-out to a single computation each.
  • Two unnecessary divisions by n - 1 factored-out, making it faster and avoiding two roundings.
  • Only one sqrt() call instead of two , making it faster and avoiding one extra rounding.

Also changed variable name in covariance() to be consistent with the other two functions.

rhettinger and others added 13 commits March 15, 2021 21:12
@rhettinger
Merge pull request #1 from python/master
bbd2da9 
Update to 15 March
@rhettinger
Merge branch 'master' of github.com:python/cpython
74bdf1b
@rhettinger
Merge branch 'master' of github.com:python/cpython
6c53f1a
@rhettinger
.
a487c4f 
Merge branch 'master' of github.com:python/cpython
@rhettinger
.
eb56423 
Merge branch 'master' of github.com:python/cpython
@rhettinger
.
cc7ba06 
Merge branch 'master' of github.com:python/cpython
@rhettinger
.
d024dd0 
Merge branch 'master' of github.com:python/cpython
@rhettinger
merge
b10f912 
Merge branch 'main' of github.com:python/cpython into main
@rhettinger
merge
0958bf0 
Merge branch 'main' of github.com:python/cpython
@rhettinger
Merge branch 'main' of github.com:python/cpython
399afee
@rhettinger
Merge branch 'main' of github.com:python/cpython
daf9f13
@rhettinger
Merge branch 'main' of github.com:python/cpython
423c26e
@rhettinger
Improve speed and accuracy for correlation()
a11ac25
@rhettinger rhettinger added performance Performance or resource usage skip issue skip news labels May 14, 2021
@rhettinger rhettinger requested a review from pablogsal May 14, 2021 18:48
@rhettinger rhettinger merged commit fdfea4a into python:main May 15, 2021
@rhettinger rhettinger added the needs backport to 3.10 only security fixes label May 15, 2021
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-26151 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 15, 2021
rhettinger pushed a commit that referenced this pull request Jun 5, 2021
@miss-islington
Improve speed and accuracy for correlation() (GH-26135) (GH-26151)
5442cfa
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@ghost ghost mentioned this pull request Jul 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
performance Performance or resource usage skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhettinger @miss-islington @bedevere-bot @the-knights-who-say-ni