bpo-38908: Fix issue when non runtime_protocol does not raise TypeError by uriyyo · Pull Request #26067 · python/cpython

uriyyo · 2021-05-12T13:54:31Z

https://bugs.python.org/issue38908

Fidget-Spinner

Yurii, thanks for sending a PR to make sure there are no regressions for this long-standing issue!

Lib/test/test_typing.py

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

uriyyo · 2021-05-12T14:34:07Z

@Fidget-Spinner It is not regression, I made a mistake when said that this issue was not present at 3.11 version. This issue still present and this PR will fix it.

Fidget-Spinner · 2021-05-12T14:40:29Z

@Fidget-Spinner It is not regression, I made a mistake when said that this issue was not present at 3.11 version. This issue still present and this PR will fix it.

Oh interesting! class P(Protocol): ... raises as expected, but

class P(Protocol): 
    x : int

doesn't!

Fidget-Spinner

LGTM. Once again, thank you for fixing this!

Misc/NEWS.d/next/Library/2021-05-12-16-43-21.bpo-38908.nM2_rO.rst

Lib/typing.py

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

gvanrossum

Thanks! Does this need backporting?

bedevere-bot · 2021-05-12T15:47:51Z

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

miss-islington · 2021-05-12T15:47:51Z

Thanks @uriyyo for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

…ror (pythonGH-26067) (cherry picked from commit c40486a) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>

bedevere-bot · 2021-05-12T15:48:05Z

GH-26073 is a backport of this pull request to the 3.10 branch.

miss-islington · 2021-05-12T15:48:06Z

Sorry, @uriyyo and @gvanrossum, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c40486a32d7e37b01ead94e701d69847f5b60e30 3.9

…ror (python#26067)

Fidget-Spinner · 2021-05-12T16:03:54Z

Sorry, @uriyyo and @gvanrossum, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c40486a32d7e37b01ead94e701d69847f5b60e30 3.9

I'm on it. It's clashing because the _allow_reckless_class_checks was previously _allow_reckless_class_cheks and the typo fix wasn't backported.

bedevere-bot · 2021-05-12T16:04:17Z

GH-26075 is a backport of this pull request to the 3.9 branch.

…ror (GH-26067) (cherry picked from commit c40486a) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>

…ypeError (GH-26067) (GH-26075) (cherry picked from commit c40486a) Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com Automerge-Triggered-By: GH:gvanrossum

… raise TypeError (pythonGH-26067) (pythonGH-26075)" This reverts commit 88136bb.

…es not raise TypeError (GH-26067)" (GH-26077) Reverts #26075 Automerge-Triggered-By: GH:gvanrossum

Backport of CPython PR 26067 (python/cpython#26067)

uriyyo requested review from gvanrossum and ilevkivskyi as code owners May 12, 2021 13:54

bedevere-bot added the awaiting review label May 12, 2021

the-knights-who-say-ni added the CLA signed label May 12, 2021

Fix issue when non runtime_protocol does not raise TypeError

53d5008

uriyyo force-pushed the fix-issue-38908 branch from ba9811d to 53d5008 Compare May 12, 2021 14:01

Fidget-Spinner self-requested a review May 12, 2021 14:11

uriyyo changed the title ~~bpo-38908: Fix issue when non runtime_protocol does not raise TypeError~~ bpo-38908: Add tests to cover case when non runtime_protocol does not raise TypeError May 12, 2021

Fidget-Spinner reviewed May 12, 2021

View reviewed changes

Lib/test/test_typing.py Outdated Show resolved Hide resolved

Fix test

179cb40

uriyyo force-pushed the fix-issue-38908 branch from 9155670 to 179cb40 Compare May 12, 2021 14:29

uriyyo changed the title ~~bpo-38908: Add tests to cover case when non runtime_protocol does not raise TypeError~~ bpo-38908: Fix issue when non runtime_protocol does not raise TypeError May 12, 2021

Update Lib/test/test_typing.py

9c66ec3

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

Fidget-Spinner added needs backport to 3.9 needs backport to 3.10 only security fixes labels May 12, 2021

Fidget-Spinner approved these changes May 12, 2021

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels May 12, 2021

Fidget-Spinner requested changes May 12, 2021

View reviewed changes

Misc/NEWS.d/next/Library/2021-05-12-16-43-21.bpo-38908.nM2_rO.rst Outdated Show resolved Hide resolved

Lib/typing.py Show resolved Hide resolved

Update Misc/NEWS.d/next/Library/2021-05-12-16-43-21.bpo-38908.nM2_rO.rst

d2baaba

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

Fidget-Spinner approved these changes May 12, 2021

View reviewed changes

gvanrossum approved these changes May 12, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels May 12, 2021

gvanrossum merged commit c40486a into python:main May 12, 2021

bedevere-bot removed the awaiting merge label May 12, 2021

bedevere-bot removed the needs backport to 3.10 only security fixes label May 12, 2021

miss-islington assigned gvanrossum May 12, 2021

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request May 12, 2021

bpo-38908: Fix issue when non runtime_protocol failed to raise TypeEr…

a1bee7e

…ror (python#26067)

bedevere-bot removed the needs backport to 3.9 label May 12, 2021

miss-islington added a commit that referenced this pull request May 12, 2021

bpo-38908: Fix issue when non runtime_protocol failed to raise TypeEr…

a2d94a0

…ror (GH-26067) (cherry picked from commit c40486a) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>

Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request May 12, 2021

Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol does not…

3ea1c0b

… raise TypeError (pythonGH-26067) (pythonGH-26075)" This reverts commit 88136bb.

miss-islington pushed a commit that referenced this pull request May 12, 2021

[3.9] Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol do…

9b90ce6

…es not raise TypeError (GH-26067)" (GH-26077) Reverts #26075 Automerge-Triggered-By: GH:gvanrossum

pablogsal mentioned this pull request Jul 18, 2021

[3.10] Correct the order of regen-abidump #27228

Closed

AlexWaygood mentioned this pull request Apr 9, 2023

Backport CPython PR 26067 python/typing_extensions#132

Merged

srittau pushed a commit to python/typing_extensions that referenced this pull request Apr 12, 2023

Fix issue when non runtime_protocol does not raise TypeError (#132)

7e998c2

Backport of CPython PR 26067 (python/cpython#26067)

This was referenced May 23, 2023

Clarify error message for non @runtime_checkable decorated protocols python/typing_extensions#178

Merged

fix(typing): add @runtime_checkable decorator for CustomTreeNode protocol class metaopt/optree#56

Merged

GiaJordan mentioned this pull request May 25, 2023

Restrict typing-extensions package to versions before v4.6.0 Sage-Bionetworks/schematic#1228

Merged

Uh oh!

Conversation

uriyyo commented May 12, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fidget-Spinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

uriyyo commented May 12, 2021

Uh oh!

Fidget-Spinner commented May 12, 2021

Uh oh!

Fidget-Spinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented May 12, 2021

Uh oh!

miss-islington commented May 12, 2021

Uh oh!

bedevere-bot commented May 12, 2021

Uh oh!

miss-islington commented May 12, 2021

Uh oh!

Fidget-Spinner commented May 12, 2021

Uh oh!

bedevere-bot commented May 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

uriyyo commented May 12, 2021 •

edited by bedevere-bot

Loading