bpo-43472: Ensure PyInterpreterState_New audit events are raised when called through _xxsubinterpreters module #25506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… called through _xxsubinterpreters module
zooba
commented
Apr 21, 2021
| @@ -2025,7 +2025,7 @@ interp_create(PyObject *self, PyObject *args, PyObject *kwds) | |||
| } | |||
|
|
|||
| // Create and initialize the new interpreter. | |||
| PyThreadState *save_tstate = PyThreadState_Swap(NULL); | |||
| PyThreadState *save_tstate = PyThreadState_Get(); | |||
| // XXX Possible GILState issues? | |||
There was a problem hiding this comment.
Maybe we can delete this comment now?
There was a problem hiding this comment.
I'm not sure the gilstate issues with subinterpreters have been resolved.
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 21, 2021
… called through _xxsubinterpreters module (pythonGH-25506) (cherry picked from commit 7b86e47) Co-authored-by: Steve Dower <steve.dower@python.org>
|
GH-25508 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 21, 2021
… called through _xxsubinterpreters module (pythonGH-25506) (cherry picked from commit 7b86e47) Co-authored-by: Steve Dower <steve.dower@python.org>
|
GH-25509 is a backport of this pull request to the 3.8 branch. |
vstinner
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43472