bpo-43655: Tkinter and IDLE dialog windows are now recognized as dialogs by window managers on macOS and X Window #25187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogs by window managers on macOS and X Window
serhiy-storchaka
added
type-feature
terryjreedy
reviewed
Apr 4, 2021
Lib/idlelib/configdialog.py
Outdated
| @@ -21,6 +21,7 @@ | |||
| from tkinter import colorchooser | |||
| import tkinter.font as tkfont | |||
| from tkinter import messagebox | |||
| from tkinter.simpledialog import _setup_dialog | |||
There was a problem hiding this comment.
As explained on the issue, I don't want this dialog changed on mac. I don't know what happens on Linux.
E-Paine
reviewed
Apr 5, 2021
There was a problem hiding this comment.
IDLE dialogs and tkinter simpledialogs fine. However, even after adding the import filedialog does not behave as expected as it does not close when the escape key is pressed (all the others do). I haven't been able to find the reason for the difference between simpledialog and filedialog yet.
Tested on MacOS (my Linux setup handled modal dialogs correctly before this patch)
EDIT:
Also, would it make more sense for _setup_dialog to be in tkinter.dialog instead?
I already added helper There is no "main" dialog file. |
Oops, ignore me! |
|
@serhiy-storchaka: Please replace |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry @serhiy-storchaka, I had trouble checking out the |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Apr 25, 2021
…s dialogs by window managers on macOS and X Window (pythonGH-25187). (cherry picked from commit 3bb3fb3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-25588 is a backport of this pull request to the 3.9 branch. |
|
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 25, 2021
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 25, 2021
…s dialogs by window managers on macOS and X Window (pythonGH-25187). (pythonGH-25588) (cherry picked from commit 3bb3fb3) (cherry picked from commit 9a16539) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43655