Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43422: Revert _decimal C API addition #24960

Merged
merged 3 commits into from
Mar 21, 2021
Merged

bpo-43422: Revert _decimal C API addition #24960

merged 3 commits into from
Mar 21, 2021

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Mar 21, 2021 •
edited by miss-islington
Loading

Stefan Krah requested the reversal of these (unreleased) changes, quoting him:

The capsule API does not meet my testing standards, since I've focused
on the upstream mpdecimal in the last couple of months.
Additionally, I'd like to refine the API, perhaps together with the
Arrow community.

https://bugs.python.org/issue43422

Automerge-Triggered-By: GH:pitrou

@pitrou pitrou requested a review from rhettinger as a code owner March 21, 2021 16:04
@pitrou
Copy link
Member Author

pitrou commented Mar 21, 2021

These changes was already reviewed in #24792, except for the trivial addition of a NEWS item.

@pitrou pitrou mentioned this pull request Mar 21, 2021
Closed
@miss-islington
Copy link
Contributor

@pitrou: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit cdddc2b into python:master Mar 21, 2021
@pitrou pitrou deleted the revert_decimal_capsule_api branch March 21, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pitrou @miss-islington @the-knights-who-say-ni @bedevere-bot @skrah