Skip to content

[3.9] bpo-42782: Fail fast for permission errors in shutil.move() (GH-24001) #24710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.9] bpo-42782: Fail fast for permission errors in shutil.move() (GH-24001) #24710

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 2, 2021 •
edited
Loading

  • Fail fast in shutil.move() to avoid creating destination directories on failure.

Co-authored-by: Zackery Spytz zspytz@gmail.com
(cherry picked from commit 132131b)

Co-authored-by: Winson Luk winson.luk@gmail.com

https://bugs.python.org/issue42782

Automerge-Triggered-By: GH:orsenthil

@winsonluk @miss-islington
bpo-42782: Fail fast for permission errors in shutil.move() (pythonGH…
6c0c7c1 
…-24001)

* Fail fast in shutil.move() to avoid creating destination directories on failure.

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
(cherry picked from commit 132131b)

Co-authored-by: Winson Luk <winson.luk@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Mar 2, 2021
Merged
@miss-islington
Copy link
Contributor Author

@miss-islington: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Contributor Author

@miss-islington: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "Ubuntu" is expected..

@miss-islington
Copy link
Contributor Author

@miss-islington: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Contributor Author

@miss-islington: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "Ubuntu" is expected..

@miss-islington
Copy link
Contributor Author

@miss-islington: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Contributor Author

@miss-islington: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "Ubuntu" is expected..

@miss-islington
Copy link
Contributor Author

@miss-islington: Status check is done, and it's a success ❌ .

@orsenthil orsenthil closed this Mar 3, 2021
@miss-islington miss-islington deleted the backport-132131b-3.9 branch March 3, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil approved these changes

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @orsenthil @the-knights-who-say-ni @bedevere-bot @winsonluk