Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43024: improve signature (in help, etc) for functions taking sent… #24331

Merged
merged 5 commits into from
Jun 17, 2021
Merged

bpo-43024: improve signature (in help, etc) for functions taking sent… #24331

merged 5 commits into from
Jun 17, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 25, 2021 •
edited by miss-islington
Loading

…inel defaults

https://bugs.python.org/issue43024

Automerge-Triggered-By: GH:pitrou

@iritkatriel iritkatriel requested a review from pablogsal January 25, 2021 15:05
iritkatriel
iritkatriel commented Jan 25, 2021
View reviewed changes
Lib/traceback.py Outdated
_sentinel = object()
class _Sentinel:
def __repr__(self):
return "<optional>"
Copy link
Member Author

@iritkatriel iritkatriel Jan 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "<derived>" (or something else?) instead of "<optional>" .

Copy link
Contributor

@taleinat taleinat May 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "<not specified>" or "<unspecified>"?

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 25, 2021
@iritkatriel iritkatriel removed the request for review from pablogsal May 13, 2021 09:13
@iritkatriel
Copy link
Member Author

iritkatriel commented Jun 17, 2021 •
edited
Loading

@pitrou - Looks like we settled on <implicit> as the best option. If we have a better pattern following @taleinat 's work we can change it later, but for now this is an improvement.

@iritkatriel iritkatriel added the needs backport to 3.10 only security fixes label Jun 17, 2021
pitrou
pitrou approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the choice @iritkatriel . Thank you!

@miss-islington miss-islington merged commit f73377d into python:main Jun 17, 2021
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 17, 2021
@iritkatriel @miss-islington
bpo-43024: improve signature (in help, etc) for functions taking sent… (
2eca542 
pythonGH-24331)

…inel defaults
(cherry picked from commit f73377d)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 17, 2021
@bedevere-bot
Copy link

GH-26773 is a backport of this pull request to the 3.10 branch.

iritkatriel added a commit that referenced this pull request Jun 17, 2021
@miss-islington @iritkatriel
bpo-43024: improve signature (in help, etc) for functions taking sent… (
eb0a680 
GH-24331) (GH-26773)

…inel defaults
(cherry picked from commit f73377d)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
@iritkatriel @jdevries3133
bpo-43024: improve signature (in help, etc) for functions taking sent… (
3010391 
pythonGH-24331)

…inel defaults
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@iritkatriel iritkatriel deleted the bpo-43024 branch November 9, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat left review comments

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iritkatriel @miss-islington @bedevere-bot @taleinat @pitrou @the-knights-who-say-ni