Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42931: Add randbytes to random.__all__ #24219

Merged
merged 3 commits into from
Jan 15, 2021
Merged

bpo-42931: Add randbytes to random.__all__ #24219

merged 3 commits into from
Jan 15, 2021

Conversation

sbalian
Copy link
Contributor

@sbalian sbalian commented Jan 15, 2021 •
edited by bedevere-bot
Loading

@sbalian sbalian requested a review from rhettinger as a code owner January 15, 2021 00:17
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@sbalian

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@rhettinger rhettinger added needs backport to 3.9 only security fixes type-bug An unexpected behavior, bug, or error labels Jan 15, 2021
@rhettinger
Copy link
Contributor

Please sign the CLA so that I can apply your PR.

@sbalian
Copy link
Contributor Author

sbalian commented Jan 15, 2021

@rhettinger Thanks, I've signed it.

@sbalian @vstinner
bpo-42931: Correct format for Misc/NEWS.d entry
1732752 
Co-authored-by: Victor Stinner <vstinner@python.org>
@rhettinger rhettinger merged commit 998ae1f into python:master Jan 15, 2021
@miss-islington
Copy link
Contributor

Thanks @sbalian for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-24225 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2021
@sbalian @miss-islington
bpo-42931: randbytes missing from random.__all__ (pythonGH-24219)
72ebccc 
(cherry picked from commit 998ae1f)

Co-authored-by: Setrak Balian <setrak@faculty.ai>
rhettinger pushed a commit that referenced this pull request Jan 15, 2021
@miss-islington
bpo-42931: randbytes missing from random.__all__ (GH-24219) (GH-24225)
17c1f0c
@vstinner
Copy link
Member

Thanks for the fix @sbalian ;-)

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@sbalian @adorilson
bpo-42931: randbytes missing from random.__all__ (pythonGH-24219)
cefdfa1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@rhettinger rhettinger rhettinger approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sbalian @the-knights-who-say-ni @rhettinger @miss-islington @bedevere-bot @vstinner