Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34805: Guarantee that __subclasses__() is in definition order. #23844

Merged
merged 1 commit into from
Dec 19, 2020
Merged

bpo-34805: Guarantee that __subclasses__() is in definition order. #23844

merged 1 commit into from
Dec 19, 2020

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Dec 18, 2020 •
edited by bedevere-bot
Loading

@rhettinger rhettinger added tests Tests in the Lib/test dir docs Documentation in the Doc dir skip news needs backport to 3.9 only security fixes labels Dec 18, 2020
pablogsal
pablogsal approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhettinger rhettinger merged commit 51f4688 into python:master Dec 19, 2020
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-23850 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 19, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 19, 2020
@rhettinger @miss-islington
bpo-34805: Guarantee that __subclasses__() is in definition order. (p…
af6eebc 
…ythonGH-23844)

(cherry picked from commit 51f4688)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
rhettinger pushed a commit that referenced this pull request Dec 19, 2020
@miss-islington
bpo-34805: Guarantee that __subclasses__() is in definition order. (G…
7826658 
…H-23844) (GH-23850)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@rhettinger @adorilson
bpo-34805: Guarantee that __subclasses__() is in definition order. (p…
7ad42f5 
…ythonGH-23844)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhettinger @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni