bpo-31904: skip some tests of changing owner in _test_all_chown_common() on VxWorks #23716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Dec 9, 2020
Lib/test/test_posix.py
Outdated
| # On VxWorks root user id is 1 and 0 means no login user. It also | ||
| # allows non-root user to chown() to root. | ||
| if sys.platform != "vxworks": | ||
| if uid == 0: |
There was a problem hiding this comment.
Would the test work if you test for "uid == 1" on VxWorks?
Something like:
root_uid = (0 if sys.platform != "vxworks" else 1)
if uid == root_uid: ...
There was a problem hiding this comment.
modified accordingly.
vstinner
reviewed
Dec 14, 2020
Co-authored-by: Victor Stinner <vstinner@python.org>
|
The updated PR is less intrusive, thanks. I merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On VxWorks root user id is 1 and 0 means no login user. It also allows non-root user to chown() to root. So related test on VxWorks is invalid. Skip them.
https://bugs.python.org/issue31904