Skip to content

[3.8] bpo-42574: Use format() instead of f-string in Tools/clinic/clinic.py to allow using older Python versions #23685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

[3.8] bpo-42574: Use format() instead of f-string in Tools/clinic/clinic.py to allow using older Python versions #23685

merged 1 commit into from
Dec 7, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Dec 7, 2020 •
edited by bedevere-bot
Loading

brandtbucher
brandtbucher approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Should this be fixed on 3.7 and 3.6, too? I think CI/tooling fixes are probably fine for security branches, but not sure. Maybe we could just set PYTHON_FOR_REGEN in .travis.yml for those.

@brandtbucher brandtbucher changed the title bpo-42574: Use format() instead of f-string in Tools/clinic/clinic.py to allow using older Python versions [3.8] bpo-42574: Use format() instead of f-string in Tools/clinic/clinic.py to allow using older Python versions Dec 7, 2020
@pablogsal
Copy link
Member Author

Should this be fixed on 3.7 and 3.6, too?

#23362 was only bacported to 3.8 no? I may be missing here something, but in any case I would be ok with backporting to 3.7 and 3.6 if applies.

@brandtbucher
Copy link
Member

Ah, you're right. I thought it was for some reason.

@pablogsal pablogsal merged commit b6d6f53 into python:3.8 Dec 7, 2020
@pablogsal pablogsal deleted the fix branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @brandtbucher @the-knights-who-say-ni @bedevere-bot