bpo-28964: add line number of node (if available) to ast.literal_eval… #23677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
force-pushed
the
bpo-28964
branch
from
d050fbc to
dd27808
Compare
isidentical
reviewed
Dec 7, 2020
isidentical
approved these changes
Dec 7, 2020
|
I still am not sure about whether this would worth it or not, so let's avoid merging it until something is decided on the bug tracker. |
|
Hey @iritkatriel, can you please drop the what's new entry? It's generally used for major improvements / new features. After that, I think we are good to go (since there is no objections!) |
iritkatriel
force-pushed
the
bpo-28964
branch
from
39d0e3c to
9cccefe
Compare
|
Thanks for the patch @iritkatriel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… error message
https://bugs.python.org/issue28964