Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41686: Always create the SIGINT event on Windows #23344

Merged
merged 2 commits into from
Nov 17, 2020
Merged

bpo-41686: Always create the SIGINT event on Windows #23344

merged 2 commits into from
Nov 17, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 17, 2020 •
edited by bedevere-bot
Loading

bpo-41686, bpo-41713: On Windows, the SIGINT event,
_PyOS_SigintEvent(), is now created even if Python is configured to
not install signal handlers (PyConfig.install_signal_handlers=0 or
Py_InitializeEx(0)).

Changes:

  • Move global variables initialization from signal_exec() to
    _PySignal_Init() to clarify that they are global variables cleared
    by _PySignal_Fini().
  • _PySignal_Fini() now closes sigint_event.
  • IntHandler is no longer a global variable.

https://bugs.python.org/issue41686

@vstinner
bpo-41686: Always create the SIGINT event on Windows
0671401 
bpo-41686, bpo-41713: On Windows, the SIGINT event,
_PyOS_SigintEvent(), is now created even if Python is configured to
not install signal handlers (PyConfig.install_signal_handlers=0 or
Py_InitializeEx(0)).

Changes:

* Move global variables initialization from signal_exec() to
  _PySignal_Init() to clarify that they are global variables cleared
  by _PySignal_Fini().
* _PySignal_Fini() now closes sigint_event.
* IntHandler is no longer a global variable.
@vstinner vstinner merged commit 0ae323b into python:master Nov 17, 2020
@vstinner vstinner deleted the signal_init branch November 17, 2020 17:15
vstinner added a commit that referenced this pull request Nov 17, 2020
@vstinner
bpo-41686: Always create the SIGINT event on Windows (GH-23344) (GH-2…
05a5d69 
…3347)

bpo-41686, bpo-41713: On Windows, the SIGINT event,
_PyOS_SigintEvent(), is now created even if Python is configured to
not install signal handlers (PyConfig.install_signal_handlers=0 or
Py_InitializeEx(0)).
vstinner added a commit that referenced this pull request Nov 17, 2020
@vstinner
bpo-41686: Always create the SIGINT event on Windows (GH-23344) (GH-2…
a702bd4 
…3347) (GH-23349)

bpo-41686, bpo-41713: On Windows, the SIGINT event,
_PyOS_SigintEvent(), is now created even if Python is configured to
not install signal handlers (PyConfig.install_signal_handlers=0 or
Py_InitializeEx(0)).

(cherry picked from commit 05a5d69)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@vstinner @adorilson
bpo-41686: Always create the SIGINT event on Windows (pythonGH-23344)
a799fd3 
bpo-41686, bpo-41713: On Windows, the SIGINT event,
_PyOS_SigintEvent(), is now created even if Python is configured to
not install signal handlers (PyConfig.install_signal_handlers=0 or
Py_InitializeEx(0)).

Changes:

* Move global variables initialization from signal_exec() to
  _PySignal_Init() to clarify that they are global variables cleared
  by _PySignal_Fini().
* _PySignal_Fini() now closes sigint_event.
* IntHandler is no longer a global variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot