Skip to content

Conversation

Pixmew
Copy link
Contributor

@Pixmew Pixmew commented Nov 15, 2020

(https://docs.python.org/3/library/imaplib.html#imap4-objects) in Documentation of imaplib under (See Also :)

The link provided by University of Washington's IMAP Information Center is not Available (https://www.washington.edu/imap/)
As the link is taken down It should be replaced by another link.
It is replaced by the Link of Source Code provided by University of Washington's IMAP Information Center on Github for the same URL (https://github.com/uw-imap/imap) (Not Currently Maintained)

https://bugs.python.org/issue42153

(https://docs.python.org/3/library/imaplib.html#imap4-objects) in Documentation of imaplib under (See Also :)
The link provided by University of Washington's *IMAP Information Center is not Available (https://www.washington.edu/imap/)
As the link is taken down It should be replaced by another link.
It is replaced by the Link of Source Code provided by University of Washington's *IMAP Information Center on Github for the same URL (https://github.com/uw-imap/imap) (Not Currently Maintained)
bpo-42153 doc: library imaplib a URL not available
@Pixmew Pixmew requested a review from a team as a code owner November 15, 2020 13:45
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 15, 2020
@Pixmew Pixmew requested review from birkenfeld and removed request for a team November 15, 2020 15:46
@Pixmew
Copy link
Contributor Author

Pixmew commented Nov 15, 2020

edited as you suggested please check it

Pixmew and others added 6 commits November 16, 2020 08:24
(https://docs.python.org/3/library/imaplib.html#imap4-objects) in Documentation of imaplib under (See Also :)
The link provided by University of Washington's *IMAP Information Center is not Available (https://www.washington.edu/imap/)
As the link is taken down It should be replaced by another link.
It is replaced by the Link of Source Code provided by University of Washington's *IMAP Information Center on Github for the same URL (https://github.com/uw-imap/imap) (Not Currently Maintained)
Comment on lines 1 to 3
Source Code of Documents describing the protocol, sources and binaries for servers
implementing it, by the University of Washington's IMAP Information Center
can all be found at (https://github.com/uw-imap/imap) (**Not Maintained**).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually small doc fixes like this don't need a news entry; if you really want a news entry, it should just read "Fix the URL for the IMAP protocol documents."

Copy link
Contributor Author

@Pixmew Pixmew Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't NEWS ENTRY required. The check fails when news entry is removed. Is there any way to skip news entry check for "Usually small doc fixes like this don't need a news entry" as you suggested?

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set a label "skip-news" so you don't need the news item.

@Pixmew
Copy link
Contributor Author

Pixmew commented Nov 16, 2020

Thank you Sir.
Really Looking forward to Contribute more.
one question :can I add or remove labels? just curious.
and why is it still saying "awaiting review" i Thought you and birkenfeld Sir reviewed it or is it something i am missing, Still new to open source contribution as this is my 2nd PR.
and would you mind pointing me to right direction like what should be my next contribution

@gvanrossum
Copy link
Member

For security reasons only people with triage or commit privilege can change labels.

@gvanrossum gvanrossum merged commit aa01011 into python:master Nov 16, 2020
@miss-islington
Copy link
Contributor

Thanks @Pixmew for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @Pixmew and @gvanrossum, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker aa01011003bb855cd52abfd49f2443446590d913 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2020
The University of Washington stopped hosting the IMAP documents. Link to a rescued copy on GitHub.
(cherry picked from commit aa01011)

Co-authored-by: Yash Shete <universeyash4@gmail.com>
@bedevere-bot
Copy link

GH-23310 is a backport of this pull request to the 3.8 branch.

@gvanrossum gvanrossum added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Nov 16, 2020
@miss-islington
Copy link
Contributor

Thanks @Pixmew for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2020
The University of Washington stopped hosting the IMAP documents. Link to a rescued copy on GitHub.
(cherry picked from commit aa01011)

Co-authored-by: Yash Shete <universeyash4@gmail.com>
@bedevere-bot
Copy link

GH-23311 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 16, 2020
miss-islington added a commit that referenced this pull request Nov 16, 2020
The University of Washington stopped hosting the IMAP documents. Link to a rescued copy on GitHub.
(cherry picked from commit aa01011)

Co-authored-by: Yash Shete <universeyash4@gmail.com>
miss-islington added a commit that referenced this pull request Nov 16, 2020
The University of Washington stopped hosting the IMAP documents. Link to a rescued copy on GitHub.
(cherry picked from commit aa01011)

Co-authored-by: Yash Shete <universeyash4@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
The University of Washington stopped hosting the IMAP documents. Link to a rescued copy on GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants