Skip to content

bpo-42357: Fix wrong availability for signal.SIGCHLD#23285

Merged
asvetlov merged 1 commit intopython:masterfrom
myzhang1029:patch-1
Nov 20, 2020
Merged

bpo-42357: Fix wrong availability for signal.SIGCHLD#23285
asvetlov merged 1 commit intopython:masterfrom
myzhang1029:patch-1

Conversation

@myzhang1029
Copy link
Contributor

@myzhang1029 myzhang1029 commented Nov 14, 2020

I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.

https://bugs.python.org/issue42357

I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@myzhang1029

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot
Copy link

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @myzhang1029 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-23425 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2020
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
(cherry picked from commit 4c24b08)

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2020
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
(cherry picked from commit 4c24b08)

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>
@bedevere-bot
Copy link

GH-23426 is a backport of this pull request to the 3.8 branch.

asvetlov pushed a commit that referenced this pull request Nov 21, 2020
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
(cherry picked from commit 4c24b08)

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>
asvetlov pushed a commit that referenced this pull request Nov 21, 2020
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
(cherry picked from commit 4c24b08)

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>

Co-authored-by: Zhang Maiyun <myzhang1029@hotmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
I believe this is a mistake. SIGCHLD is only available on Unix systems, not Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants