-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: os.path.abspath and Path.resolve are also different #23276
Conversation
Hi @xuhdev and thanks for the PR! Can you extrapolate on their differences? I bet at this point specific comments should be added for each diverging pair of functions, so a developer converting from |
@JulienPalard I agree, added |
There's a doctest failing in the build. Would you be able to look into it? |
c8911b2
to
377111d
Compare
@Mariatta Thanks for the reminder. The doctest has been fixed now. |
That's better with the explanations, and I learnt something. I'm not fan of the 187 character wide table though. An idea: you could use footnotes for this? Like:
followed by :
|
4d04cef
to
2ec4a20
Compare
@JulienPalard Thanks, I have updated the PR to use footnotes. |
@Mariatta Some required tests are skipped, if I understand correctly that's why it says checks are not successful? |
Somehow the Travis I build is in "Cancelled" status. Perhaps we need to restart it. |
Add more explanation to point out that os.path.abspath and Path.resolve are also not equivalent.
@Mariatta @JulienPalard I rebase the PR so all tests have now been retriggered. |
We're aware of the issue with bedevere skip-issues/news status https://mail.python.org/archives/list/python-committers@python.org/message/4QD47S5OB4EVC6A2QTT7EH26EQBW4PGR/ |
Can we proceed with this PR? It's been 3 weeks since last activity. |
@xuhdev thanks for the PR :) |
And thanks for all the feed back :) |
Add more explanation to point out that os.path.abspath and Path.resolve
are also not equivalent.