Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in unicodeobject.c #23180

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Fix typo in unicodeobject.c #23180

merged 1 commit into from
Nov 10, 2020

Conversation

eltociear
Copy link
Contributor

@eltociear eltociear commented Nov 6, 2020 •
edited by miss-islington
Loading

exeeds -> exceeds

Automerge-Triggered-By: GH:Mariatta

@eltociear
Fix typo in unicodeobject.c
39d22ea 
exeeds -> exceeds
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@eltociear

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Mariatta
Mariatta approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@miss-islington miss-islington merged commit 38811d6 into python:master Nov 10, 2020
@miss-islington
Copy link
Contributor

Thanks @eltociear for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2020
@eltociear @miss-islington
Fix typo in unicodeobject.c (pythonGH-23180)
0393bd6 
exeeds -> exceeds

Automerge-Triggered-By: GH:Mariatta
(cherry picked from commit 38811d6)

Co-authored-by: Ikko Ashimine <eltociear@gmail.com>
@bedevere-bot
Copy link

GH-23215 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 10, 2020
@eltociear
Copy link
Contributor Author

@Mariatta @miss-islington Thanks too!

miss-islington added a commit that referenced this pull request Nov 10, 2020
@miss-islington @eltociear
Fix typo in unicodeobject.c (GH-23180)
2a86ade 
exeeds -> exceeds

Automerge-Triggered-By: GH:Mariatta
(cherry picked from commit 38811d6)

Co-authored-by: Ikko Ashimine <eltociear@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@eltociear @adorilson
Fix typo in unicodeobject.c (pythonGH-23180)
4233267 
exeeds -> exceeds

Automerge-Triggered-By: GH:Mariatta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eltociear @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta