bpo-29591: [2.7] Update VS project files #2310
Conversation
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Can you please elaborate the commit message to list removed define and explain that they are now already defined in Modules/expat/winconfig.h?
PC/VS9.0/pyproject.vsprops
Outdated
There was a problem hiding this comment.
I'm not sure that this change is still needed with expat 2.2.1. Would you mind to check please?
There was a problem hiding this comment.
Actually this is unrelated to just Expat. It brings the VS9.0 project files inline with the MSBuild ones. Ever wonder why the Expat change "just worked" on the other releases? ;)
There was a problem hiding this comment.
Ok fine. I'm just surprised that we have to define it manualy. It should already be defined by <windows.h> no?
|
The overall change LGTM, except of my (minor) comments. Can you please rebase it since I just merged my expat 2.2.1 change? |
jkloth
force-pushed
the
issue29591-expat-2.2.0
branch
from
6782ae7 to
80aa260
Compare
* Silence warnings caused by duplicated defines from Modules\expat\winconfig.h * Add WIN32 define to VS9.0 project files to match MSBuild project files.
jkloth
force-pushed
the
issue29591-expat-2.2.0
branch
from
80aa260 to
153dfe6
Compare
|
Rebased and modified commit message. |
|
The ch1nge looks safe and should at least fix the HAVE_MEMMOVE warning. Thanks. |
3 participants
Updates the Visual Studio project files to fix regressions due to Expat 2.2.0