Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42224: Fix test_format when locale does not expect number grouping #23067

Merged
merged 1 commit into from
Nov 2, 2020
Merged

bpo-42224: Fix test_format when locale does not expect number grouping #23067

merged 1 commit into from
Nov 2, 2020

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Oct 31, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Oct 31, 2020
ericvsmith
ericvsmith approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do you want to backport to 3.9 and 3.8?

@lysnikolaou
Copy link
Member Author

lysnikolaou commented Oct 31, 2020 •
edited
Loading

Looks good to me. Do you want to backport to 3.9 and 3.8?

I guess it makes sense to do so, yeah. What do you think?

@lysnikolaou lysnikolaou merged commit 3018228 into python:master Nov 2, 2020
@miss-islington
Copy link
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@lysnikolaou lysnikolaou deleted the test-format-locale-fix branch November 2, 2020 15:27
@miss-islington
Copy link
Contributor

Sorry @lysnikolaou, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 301822859b3fc34801a06f1090d62f9f2ee5b092 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2020
@lysnikolaou @miss-islington
bpo-42224: Fix test_format when locale does not expect number grouping (
bea88cb 
pythonGH-23067)

(cherry picked from commit 3018228)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-bot
Copy link

GH-23110 is a backport of this pull request to the 3.8 branch.

lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Nov 2, 2020
@lysnikolaou
[3.9] bpo-42224: Fix test_format when locale does not expect number g…
2b23a33 
…rouping (pythonGH-23067)

(cherry picked from commit 3018228)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 2, 2020
@bedevere-bot
Copy link

GH-23111 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 2, 2020
@miss-islington @lysnikolaou
bpo-42224: Fix test_format when locale does not expect number grouping (
1e96de9 
GH-23067)

(cherry picked from commit 3018228)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
lysnikolaou added a commit that referenced this pull request Nov 2, 2020
@lysnikolaou
bpo-42224: Fix test_format when locale does not expect number grouping (
723e21a 
GH-23067)

(cherry picked from commit 3018228)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@lysnikolaou @adorilson
bpo-42224: Fix test_format when locale does not expect number grouping (
c12b7ef 
pythonGH-23067)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

@lysnikolaou lysnikolaou

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lysnikolaou @miss-islington @bedevere-bot @ericvsmith @the-knights-who-say-ni