DOC: attribute PyPy for the idea behind the optimization #23036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Oct 30, 2020
Doc/whatsnew/3.10.rst
Outdated
| @@ -261,7 +261,8 @@ Optimizations | |||
|
|
|||
| * The ``LOAD_ATTR`` instruction now uses new "per opcode cache" mechanism. | |||
| It is about 36% faster now. (Contributed by Pablo Galindo and Yury Selivanov | |||
| in :issue:`42093`.) | |||
| in :issue:`42093`, based on ideas from Victor Stinner and the original | |||
| implementation in PyPy.) | |||
There was a problem hiding this comment.
I have nothing to do with that! Please remove my name :-)
There was a problem hiding this comment.
I think that the only thing that I did was to say to some core devs (INADA-san, Yury and Pablo?) that PyPy has some cool optimizations that we could "easily" reimplement in CPython.
The website can be found at: https://faster-cpython.readthedocs.io/ Enjoy the first new pages about garbage collection and a tracing GC for CPython ;-) |
pablogsal
reviewed
Oct 30, 2020
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal
approved these changes
Oct 30, 2020
|
Thanks for the PR @mattip ! |
|
I like the final merged change, thanks ;-) |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this tweet, the origin for the idea is the mail from 2016, which mentions @vstinner 's "faster-python" document (which seems to be lost, the link in the mail is broken). In particular this optimization was first implemented in PyPy.
While normally I don't care about attribution, the recent interchange on the python-dev mailing list that implied PyPy is not important got my hackles up, especially because this is the second such optimization implemented with no mention of PyPy.